Send in AgentLink #1214
Closed
Send in AgentLink #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkawalec
commented
May 12, 2020
| /// This method called on every incoming message. | ||
| fn handle_input(&mut self, msg: Self::Input, id: HandlerId); | ||
|
|
||
| /// This method called on when a new bridge created. |
There was a problem hiding this comment.
Moved this down to have the required functions before optional
mkawalec
commented
May 12, 2020
yew/src/agent/link.rs
Outdated
| } | ||
| } | ||
|
|
||
| #[test] |
There was a problem hiding this comment.
This is not picked up by cargo test --doc --features doc_test,wasm_test,yaml,msgpack,cbor,toml \ --features std_web,agent,services --no-default-features for some reason
|
Tests are a somewhat orthogonal concern, removed them for now, we might want to create an issue to add a testing scaffold to Agents. Ready for review. |
|
closing in favor of #1215 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1209
IssueHunt Summary