-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix benchmark action for pull requests from forks #1315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this could be rewritten as two separate actions – one to run on push (with comments) and one to run on pull requests (without comments).
@teymour-aldridge where would it post the comments on |
Oh, that's true. Perhaps a |
@teymour-aldridge I thought about this too, but how often is there going to be a pull request that doesn't originate from a fork? |
That's true. I've noticed that some Github apps are able to add comments for pull requests for third parties, but that would be something to look into for a later PR I think. |
I was curious about that too but I think they're all using integrated apps to do it. |
* remove GITHUB_TOKEN * no more need to escape the message
Description
The workflow currently doesn't work on pull requests because the
GITHUB_TOKEN
only has read-only permissions.There seems to be no way to solve this currently so this PR removes the comment functionality entirely.
Instead, the results are now logged to the console which is less exciting but it should at least work.
Fixes #1311