Add From<&[T]> for Classes #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siku2
previously approved these changes
Jul 25, 2020
|
Looks like the same thing that happened on my other PR, before I started adding more commits, which re-triggered subsequent builds, but then only one at a time instead of this doubling up. It fires up the same build twice, and only one of the two "checks" get notified of its completion. Like if you click on the "Details" for the one that is "Queued - Build Created" and click "The Build" of "The build created." on that page, it takes you to a finished, successful build. |
jstarry
pushed a commit
that referenced
this pull request
Aug 16, 2020
* Add From<&[T]> for Classes * Round out the test cases for From<&[T]> for Classes
teymour-aldridge
pushed a commit
to teymour-aldridge/yew
that referenced
this pull request
Sep 1, 2020
* Add From<&[T]> for Classes * Round out the test cases for From<&[T]> for Classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an implementation
impl<T: AsRef<str>> From<&[T]> for Classesso that you can use anything that can produce slices with theclassattribute.Checklist:
./ci/run_stable_checks.sh