Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate with props error messages. #1730

Merged
merged 3 commits into from
Feb 5, 2021
Merged

Fix duplicate with props error messages. #1730

merged 3 commits into from
Feb 5, 2021

Conversation

teymour-aldridge
Copy link
Contributor

@teymour-aldridge teymour-aldridge commented Feb 5, 2021 •
edited
Loading

Description

Sorry wrong issue (oops) – actually fixes #1631

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

@teymour-aldridge @siku2
Use quote! for error message.
cd3aa90 
Co-authored-by: Simon <simon@siku2.io>
@siku2 siku2 merged commit 0b90a3d into yewstack:master Feb 5, 2021
@siku2
Copy link
Member

siku2 commented Feb 5, 2021

This might've actually been the first issue of mine that was fixed by someone else 😊

@teymour-aldridge
Copy link
Contributor Author

teymour-aldridge commented Feb 6, 2021 •
edited
Loading

I have to say, your issue descriptions are very nice and detailed.

@voidpumpkin voidpumpkin added the A-yew-macro Area: The yew-macro crate label Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siku2 siku2 siku2 left review comments

Assignees
No one assigned
Labels
A-yew-macro Area: The yew-macro crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

with props syntax doesn't error if multiple props are provided
3 participants
@teymour-aldridge @siku2 @voidpumpkin