Generic functional components #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 014ccec): https://yew-rs--pr1756-lukechu10-function-c-snu53uqz.web.app (expires Tue, 02 Mar 2021 23:13:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
Is this still a draft? There are a lot of TODO comments left. Btw, please update your "pass" tests such that they bring as few members as possible into scope. This helps ensure that the macro code is (and more importantly stays) hygienic. |
|
Yeah, I'll try to improve the error messages some more as well as the pass test :) |
|
I also want to try this out with const generics |
|
Ok, const generics seem to be working. I can't enable it in the CI tests because it is not in stable yet. |
|
Everything seems to be working now :) |
siku2
reviewed
Feb 23, 2021
packages/yew-functional-macro/tests/function_attr/generic-lifetime-fail.rs
Outdated
Show resolved
Hide resolved
packages/yew-functional-macro/tests/function_attr/generic-props-fail.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Simon <simon@siku2.io>
Co-authored-by: Simon <simon@siku2.io>
Co-authored-by: Simon <simon@siku2.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements parsing and expansion for generic
#[function_component]components.Fixes #1739
Checklist
cargo make pr-flow