Bring the context method more inline with other Yew APIs by separating #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
registration from getting the current context value.
18 tasks
|
Looks to me in https://yew.rs/next/concepts/contexts there is an example where you can pass a callback that would trigger on changes, thus i dont think this is an an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registration from getting the current context value.
Description
The
context()method on scopes now returns aContext<T>object. This object has separate methods to access the current context vs listen for when the context changes. Theuse_contexthook continues to automatically do both.The need for this split became apparant during the work on #1860 but makes sense to merge separately.
Checklist
cargo make pr-flow