Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduler main queue delay (#1953) #1954

Merged
merged 2 commits into from
Jul 16, 2021

Conversation

intendednull
Copy link
Contributor

@intendednull intendednull commented Jul 16, 2021

Fixes #1953

Executes pending runnables immediately after adding to the main queue. This was the previous behavior (before #1903).

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

Fixes an issue where a runnable added from outside the component
lifecyle (i.e. agent bridge message from inside a callback) would not be
executed until the next component lifecycle event.
@teymour-aldridge
Copy link
Contributor

Is it possible to add a test for this?

Ensures `scheduler::run` executes runnables immediately.
@intendednull
Copy link
Contributor Author

@teymour-aldridge good idea! Added and pushed :)

@siku2 siku2 merged commit 91ab14b into yewstack:master Jul 16, 2021
@voidpumpkin voidpumpkin added the A-yew Area: The main yew crate label Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scheduler delays runnable when added outside component lifecycle
4 participants