Static attribute lists #1962
Merged
Static attribute lists #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xavientois
reviewed
Jul 19, 2021
ranile
requested changes
Jul 19, 2021
Co-authored-by: Muhammad Hamza <muhammadhamza1311@gmail.com>
…ew into optimize/static-attribute-lists
mc1098
reviewed
Jul 22, 2021
Co-authored-by: mc1098 <m.cripps1@uni.brighton.ac.uk>
voidpumpkin
added
A-yew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Build attribute key or entire key-value lists at compile time. This reduces allocation size for dynamic attribute vectors and allows performing cheap array pointer equality checks for the hottest attribute comparison paths.
Benchmark results:
Checklist
cargo make pr-flow