Fix default passive option

[mc1098]

Description

This PR sets the passive option explicitly in order to override any defaults the browsers might have - this is especially needed because with #1542 we attach listeners to the body element which is at the document level.
See this article section about default passive behaviour on some document level events.

Fixes #2110

Checklist

• I have run cargo make pr-flow
• I have reviewed my own code
• I have added tests

[NickHu]

Could we add a way to make the result from Callback::from explicitly non/passive?

[mc1098]

Callbacks created using From::from will not be passive by default, apart from these:

yew/packages/yew/src/html/listener/events.rs

Lines 211 to 216 in 77b46bf

	impl_passive! {
	onscroll(Event)
	ontouchmove(TouchEvent)
	ontouchstart(TouchEvent)
	}

We should add a way for users to create a passive Callback for function components, which I guess is your point but I think a factory function would be more clear then another impl of From::<T>::from, I'm not even sure what T would be in that impl.

Regardless, I think adding this should occur in a different PR and that PR should also include any other missing ways of constructing a Callback which is available through Scope.

[NickHu]

I am slightly confused by what you said, as it seems as though onwheel callbacks are passive; hence what I described in #2110. Maybe this is unintentional, and after the fix in this PR they won't be.

[mc1098]

I am slightly confused by what you said, as it seems as though onwheel callbacks are passive; hence what I described in #2110.

Oh sorry! I meant in terms of the defaults yew uses. This PR is really letting yew override whatever default the browser might have - I think we assumed passive would be false unless set otherwise, but this doesn't seem to be the case, which is why we need to explicitly set the flag.

Maybe this is unintentional, and after the fix in this PR they won't be.

So for these three after this PR, they will still default to passive, unless the user explicitly sets the passive flag to false :)

[mc1098]

@siku2 sanity check please 🙃

[siku2]

Weird, my memory tells me that the DOM Standard dictates the passive flag to init to false.
Does this actually fix the issue?

[mc1098]

Does this actually fix the issue?

It did for me - I used the example provided in #2110 and found that I got errors in both firefox and chrome, then implemented this change and it worked :)

Weird, my memory tells me that the DOM Standard dictates the passive flag to init to false.

"passive (a boolean, initially false)" - Your memory is correct 🙃. This feature seems to contradict what the standard says and this seems to apply to Edge as well, though I didn't test Edge.

[siku2]

@mc1098 thanks a lot for checking!
Looks like this patch is definitely necessary then and I don't see a reason not to merge it.