Remove router state

[voidpumpkin]

Description

During #2118 router state was reintroduced, even though there were previous efforts to remove it by @hamza1311
This PR removes the re-added state

Checklist

• I have run cargo make pr-flow
• I have reviewed my own code
• I have added tests

[voidpumpkin]

@futursolo Sorry for my bad review on that PR :D

[ranile]

@futursolo wants to move history/location access to Gloo (rustwasm/gloo#166). I think it'd be better swap out the entire code with Gloo, instead of removing parts of it right now

[voidpumpkin]

@futursolo wants to move history/location access to Gloo (rustwasm/gloo#166). I think it'd be better swap out the entire code with Gloo, instead of removing parts of it right now

I see, well I can close this PR, we can always reopen if needed

[futursolo]

May I ask what's the rationale of removing state from history?

[voidpumpkin]

@futursolo It adds more complexity for router related components like Link and Redirect. While it is possible to pass state by other means in yew.
I'm not inherently against it, its just sometimes less is more.

[futursolo]

It adds more complexity for router related components like Link and Redirect.

I am not sure I understand this?
This PR does not seem to remove anything from those components.

The rationale of having a state on the history is as following, for example, if you want to preserve the scrolling position during navigations:

history.push_with_state(Path::A, State { scroll_y: 123 }); // id: 0
history.push_with_state(Path::B, State { scroll_y: 456 }); // id: 1
history.push_with_state(Path::A, State { scroll_y: 133 }); // id: 2

If one wants to implement this without access to history-based state, it will be very difficult as there will be no other way to reliably figure out which page the user is currently on (in terms of session history position, like, how to distinguish between id 0 and 2). JavaScript version of history provides a unique key to distinguish between navigations, but as far as I know, it is also implemented using window.history.state.

(FWIW, this GitHub page uses history-based state.)