Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move yew-agent to gloo #2326

Merged
merged 4 commits into from
Jan 5, 2022
Merged

Move yew-agent to gloo #2326

merged 4 commits into from
Jan 5, 2022

Conversation

ranile
Copy link
Member

@ranile ranile commented Jan 2, 2022

Description

This PR moves yew-agent to gloo, making it framework independent in the process. The yew-agent crate still exists as it contains the hooks used to interface with Workers

Also see: rustwasm/gloo#180

TODO:

  • Documentation
    What should be in documentation?

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

@ranile ranile added blocked A-yew-agent Area: The yew-agent crate breaking change labels Jan 2, 2022
github-actions[bot]
github-actions bot previously approved these changes Jan 2, 2022
github-actions[bot]
github-actions bot previously approved these changes Jan 2, 2022
Copy link
Member

@voidpumpkin voidpumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have clippy errors aswell

packages/yew-agent/Cargo.toml Outdated Show resolved Hide resolved
@ranile ranile removed the blocked label Jan 5, 2022
@ranile ranile requested a review from voidpumpkin January 5, 2022 14:14
@ranile
Copy link
Member Author

ranile commented Jan 5, 2022

Since gloo-worker has the same API as yew-agent previous did and we re-export it, it's not a breaking change

Copy link
Member

@voidpumpkin voidpumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew-agent Area: The yew-agent crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants