-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename suffixes from .mdx to .md #2353
Conversation
Visit the preview URL for this PR (updated for commit 9c3f7ca): https://yew-rs--pr2353-docs-mdx-to-md-1xzyvthn.web.app (expires Wed, 19 Jan 2022 15:02:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
@futursolo |
|
Please see the fix here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@Madoshakalaka please rebase the changes from master. Looks good otherwise |
# Conflicts: # tools/website-test/build.rs # website/README.md
hmmm I don't think I understand the mechanisms of merge conflicts fully...but anyways, the PR branch does have the correct |
it has correct file extension because your branch is not rebased onto latest master branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to avoid github conflicts magic, i will only approve once this is rebased.
nvm i pieced it together. |
closed because GitLocalize now has MDX support! See gitlocalize/feedback#112 |
GitLocalize can't recognize .mdx suffixes.
What's wrong with you GitLocalize??