Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[events.mdx] relative link to use_deps_with_effects fixed #2491

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

kolloch
Copy link
Contributor

@kolloch kolloch commented Mar 4, 2022

Description

Fix for #2486 as suggested by @hamza1311

(not sure how to test whether the link is correct now)

@ranile
Copy link
Member

ranile commented Mar 4, 2022

(not sure how to test whether the link is correct now)

You click on the link and check if it navigates to the correct page

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

Visit the preview URL for this PR (updated for commit 3c61b7f):

https://yew-rs--pr2491-feature-events-link-opsq48up.web.app

(expires Fri, 11 Mar 2022 09:05:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@kolloch
Copy link
Contributor Author

kolloch commented Mar 4, 2022

(not sure how to test whether the link is correct now)

You click on the link and check if it navigates to the correct page

How? You mean in the github preview? I meant before submitting a merge request ;) The rendered page is different.

Anyways, I could verify the problem in the currently rendered version:

https://yew.rs/docs/next/concepts/html/events#using-eventlistener-in-a-function-component

I think it should work now.

Currently, the link points to:

https://yew.rs/docs/next/concepts/html/function-components/hooks/use-effect#applying-event-listeners-to-the-dom

and it should link to (without the html)

https://yew.rs/docs/next/concepts/function-components/hooks/use-effect#applying-event-listeners-to-the-dom

so your suggestion should work.

@kolloch
Copy link
Contributor Author

kolloch commented Mar 4, 2022

Visit the preview URL for this PR (updated for commit 3c61b7f):

https://yew-rs--pr2491-feature-events-link-opsq48up.web.app

(expires Fri, 11 Mar 2022 09:05:46 GMT)

fire via Firebase Hosting GitHub Action earth_americas

I honestly missed this 👍 Now that's obvious.

I guess that I missed it because it appears only after someone whitelists the PR for actions.

@kolloch
Copy link
Contributor Author

kolloch commented Mar 4, 2022

@ranile ranile enabled auto-merge (squash) March 4, 2022 12:43
@siku2 siku2 merged commit 3a11f15 into yewstack:master Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants