Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow macro invocations as prop values #2687

Merged
merged 2 commits into from
May 18, 2022

Conversation

WorldSEnder
Copy link
Member

Description

Fixes #2267

Checklist

  • I have reviewed my own code
  • I have added tests

Sorry, something went wrong.

Unverified

The email in this signature doesn’t match the committer email.
convert macro invocation Item statements to Exprs

Unverified

The email in this signature doesn’t match the committer email.
@github-actions
Copy link

github-actions bot commented May 16, 2022

Visit the preview URL for this PR (updated for commit e5c561d):

https://yew-rs--pr2687-macro-prop-value-bdqv9onk.web.app

(expires Mon, 23 May 2022 16:00:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@WorldSEnder WorldSEnder added this to the v0.20 milestone May 16, 2022
@github-actions
Copy link

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
boids 172.800 172.800 0 0.000%
contexts 109.644 109.644 0 0.000%
counter 86.653 86.653 0 0.000%
counter_functional 87.306 87.306 0 0.000%
dyn_create_destroy_apps 89.770 89.770 0 0.000%
file_upload 102.623 102.623 0 0.000%
function_memory_game 167.383 167.383 0 0.000%
function_router 350.668 350.668 0 0.000%
function_todomvc 162.005 162.005 0 0.000%
futures 226.659 226.659 0 0.000%
game_of_life 107.512 107.512 0 0.000%
inner_html 83.688 83.688 0 0.000%
js_callback 112.870 112.870 0 0.000%
keyed_list 195.030 195.030 0 0.000%
mount_point 86.279 86.279 0 0.000%
nested_list 115.917 115.917 0 0.000%
node_refs 90.448 90.448 0 0.000%
password_strength 1539.047 1539.047 0 0.000%
portals 97.192 97.192 0 0.000%
router 319.723 319.723 0 0.000%
simple_ssr 494.016 494.016 0 0.000%
ssr_router 425.758 425.758 0 0.000%
suspense 110.532 110.532 0 0.000%
timer 89.392 89.392 0 0.000%
todomvc 143.053 143.053 0 0.000%
two_apps 87.287 87.287 0 0.000%
web_worker_fib 153.540 153.540 0 0.000%
webgl 87.375 87.375 0 0.000%

✅ None of the examples has changed their size significantly.

@WorldSEnder WorldSEnder merged commit 6f6c61b into yewstack:master May 18, 2022
@WorldSEnder WorldSEnder deleted the macro-prop-value branch May 18, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using html[_nested]! { ... } as a prop value produces an obscure error
2 participants