Support passing a struct instance as properties #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! @limira Thank you for the PR and the idea 👍 |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 7, 2018
271: Support passing a struct instance as properties r=DenisKolodin a=limira
If we have
```rust
#[derive(Debug, Default, Eq, PartialEq)]
pub struct MyProps {
val: i32,
}
impl Component<Context> for MyComp {
type Message = Msg;
type Properties = MyProps;
}
```
then if we have an instance of `MyProps`, we can pass it directly to its Component:
```rust
let my_props = MyProps {val: 64 };
html! {
<MyComp: props=my_props, />
}
```
Is there a better syntax for this?
If this is merged as is, any `struct` that is used for a Component's properties will not allowed to contain a field named `props`!
Edit: I you merge this, please squash all commits. While working on this, I got stuck by an error I don't know how to solve, just commit to get back to the original working code (from master).
Co-authored-by: Limira <20672976+limira@users.noreply.github.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have
then if we have an instance of
MyProps, we can pass it directly to its Component:Is there a better syntax for this?
If this is merged as is, any
structthat is used for a Component's properties will not allowed to contain a field namedprops!Edit: I you merge this, please squash all commits. While working on this, I got stuck by an error I don't know how to solve, just commit to get back to the original working code (from master).