Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A new minimal example that work with PR #272 #277

Merged
merged 1 commit into from
Jun 17, 2018
Merged

A new minimal example that work with PR #272 #277

merged 1 commit into from
Jun 17, 2018

Conversation

limira
Copy link
Contributor

@limira limira commented Jun 8, 2018 •
edited
Loading

It is the example in src/lib.rs.

huangjj27
huangjj27 reviewed Jun 12, 2018
View reviewed changes
src/lib.rs
//!
//! impl Component for Model {
//! type Message = Msg;
//! type Properties = ();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better adding another example that is showing how to use Properties?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such an example requires at least two component, doesn't it? It's a big one, I don't think it is suitable in lib.rs. We have plenty of such examples in /examples/*.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huangjj27 Thank you for the idea. I think it's better to remain () for Properties to show you could avoid this parameter for application components.

@therustmonk
Copy link
Member

Thank you for the PR! I'll merge it immediately after #277. I'm on a business trip now, but I'll return to end of the week and will deal with it.

@huangjj27
Copy link
Contributor

I'll merge it immediately after #277.

@deniskolodin I think you mean #272, which is merged.

@limira
Copy link
Contributor Author

limira commented Jun 17, 2018

@huangjj27, I think we should give @deniskolodin a little break, I think he worked really hard last few weeks!

@therustmonk
Copy link
Member

Oh, sorry! It was busy weeks and I forgot about it. Thank you for care! ☺️
It's bors time )

@therustmonk
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jun 17, 2018
@bors
Try #277:
1b05ce9
@bors
Copy link
Contributor

bors bot commented Jun 17, 2018

try

Build succeeded

@therustmonk
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jun 17, 2018
@bors @limira
Merge #277
bde3612 
277: A new minimal example that work with PR #272 r=DenisKolodin a=limira

It is the example in `src/lib.rs`.

Co-authored-by: Limira <20672976+limira@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Jun 17, 2018

Build succeeded

@bors bors bot merged commit aa5132f into yewstack:master Jun 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huangjj27 huangjj27 huangjj27 left review comments

@therustmonk therustmonk therustmonk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@limira @therustmonk @huangjj27