-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention certain components must be children of Router #2913
Mention certain components must be children of Router #2913
Conversation
I've been using yew for a little bit now and have some ideas about improving documentation for yew. These aren't complete thoughts, but I just wanted to share what was on my mind as it might be helpful. Also to share my experience reading the docs:
I'm not in the loop about what is being done with the docs, but my suggestion is to overall structure the documentation more like reacts. Yew does this to an extent already, but it could be better e.g.
TLDR; more code and detail to describe and communicate the concepts Also, I'm willing to help with more documentation efforts especially with the things I've had a bit of trouble with like passing a function as a prop Also, as a general question is it just better to put up PRs here rather than just propose things? |
If you have a ready proposition that improves things, a PR is welcome. If it's unclear what to change and you want to figure things out first, the have a few tags you can apply to your issue, among them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall nicer to read. I think the phrasing is still a bit verbose and vague. A link to the context docs could be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fixes need to be added in both files
Also, I'll squash these commits together into one whenever merging |
Just wanted to bump this it's been a little while. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noticed some small typos
Visit the preview URL for this PR (updated for commit c574adb): https://yew-rs--pr2913-sasa-update-router-d-29rueg3o.web.app (expires Thu, 15 Dec 2022 06:19:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Hey. @sasacocic . Just wanted to let you know that I really appreciate your patience on this :D It might feel like this is getting more scrutiny and change requests than a usual documentation change, which I think is because we're nearing release and want to get it exactly right. Thanks for your perseverance and understanding in keeping up with all the different opinions. |
@WorldSEnder no worries :) |
Sorry, I forgot this PR was waiting on me. @sasacocic can you please update the PR so it can be merged. If you don't want to, that's fine. I can do that for you |
743348a
to
001ce08
Compare
@hamza1311 I've updated it. Along with the documentation for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for also updating the old docs, there are still quite a lot users around, so it's worth the effort. Only comment from me is fixing some missing quotes for code markup.
Description
I've added documentation explaining that certain elements like
<Link />
&<Switch />
must be nested inside of a router.Fixes #2903