-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix top-level reconciliation in portals #3020
Fix top-level reconciliation in portals #3020
Conversation
Visit the preview URL for this PR (updated for commit 88386fb): https://yew-rs-api--pr3020-fix-portal-reconcili-gp292iyx.web.app (expires Tue, 13 Dec 2022 07:49:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - SSRYew Master
Pull Request
|
Size Comparison
✅ None of the examples has changed their size significantly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Seems like we should cut a new patch release soon
Description
Portals would incorrectly use their own
parent
andnext_sibling
to reconcile their contents since #2330. Oops. This did not affect the reconciliation of nested elements, which could be a reason this was undetected for this long.Fixes #3017
A workaround for anyone impacted by this (until the next patch release) would be to nest elements in a tag that does not change, which is not applicable in all situations.
Checklist