-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try fixing the post-comment benchmark action, take 2 #3047
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WorldSEnder
changed the title
Fix benchmark
Try fixing the post-comment benchmark action, take 2
Dec 17, 2022
WorldSEnder
force-pushed
the
fix-benchmark
branch
from
December 17, 2022 13:52
cc0b4fc
to
98eb5e7
Compare
Benchmark - SSRYew Master
Pull Request
|
Size Comparison
✅ None of the examples has changed their size significantly. |
ranile
approved these changes
Dec 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not aware of any way to run these actions locally. Generally they're tested in PRs but the post-* actions can't be tested without merging because they're picked from master
WorldSEnder
added
A-tools
Area: Tools such as trunk, wasm-bindgen
A-ci
Area: The continuous integration
and removed
A-tools
Area: Tools such as trunk, wasm-bindgen
labels
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See actions/runner#1656 why the previous attempt failed. Pass the expression to echo to the file as an environment variable. This is all so needlessly convoluted.
Also fixes 2 clippy issues.
If you know a way of running the actions locally without having to setup a couple gigabytes of docker machines that will just lay around, let me know and I'll do it. I kinda just hand-transpile the commands to a local bash session atm.