Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fixing the post-comment benchmark action, take 2 #3047

Merged
merged 3 commits into from
Dec 17, 2022

Conversation

WorldSEnder
Copy link
Member

@WorldSEnder WorldSEnder commented Dec 17, 2022

Description

See actions/runner#1656 why the previous attempt failed. Pass the expression to echo to the file as an environment variable. This is all so needlessly convoluted.

Also fixes 2 clippy issues.


If you know a way of running the actions locally without having to setup a couple gigabytes of docker machines that will just lay around, let me know and I'll do it. I kinda just hand-transpile the commands to a local bash session atm.

@WorldSEnder WorldSEnder changed the title Fix benchmark Try fixing the post-comment benchmark action, take 2 Dec 17, 2022
github-actions[bot]
github-actions bot previously approved these changes Dec 17, 2022
github-actions[bot]
github-actions bot previously approved these changes Dec 17, 2022
@github-actions
Copy link

github-actions bot commented Dec 17, 2022

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 344.107 345.404 344.615 0.465
Hello World 10 650.609 654.394 651.582 1.091
Function Router 10 2282.298 2293.015 2287.939 3.519
Concurrent Task 10 1007.967 1010.359 1009.163 0.792

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 264.336 300.405 289.319 16.945
Hello World 10 555.177 651.571 619.701 38.148
Function Router 10 1977.339 2253.482 2139.474 136.271
Concurrent Task 10 1007.989 1009.913 1009.046 0.640

@github-actions
Copy link

github-actions bot commented Dec 17, 2022

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 108.237 108.237 0 0.000%
boids 172.272 172.272 0 0.000%
communication_child_to_parent 92.360 92.358 -0.002 -0.002%
communication_grandchild_with_grandparent 106.809 106.805 -0.004 -0.004%
communication_grandparent_to_grandchild 102.650 102.653 +0.003 +0.003%
communication_parent_to_child 89.447 89.449 +0.002 +0.002%
contexts 109.333 109.338 +0.005 +0.004%
counter 87.387 87.385 -0.002 -0.002%
counter_functional 87.802 87.802 0 0.000%
dyn_create_destroy_apps 90.236 90.234 -0.002 -0.002%
file_upload 101.704 101.708 +0.004 +0.004%
function_memory_game 166.447 166.462 +0.015 +0.009%
function_router 349.913 349.928 +0.015 +0.004%
function_todomvc 161.408 161.413 +0.005 +0.003%
futures 226.536 226.533 -0.003 -0.001%
game_of_life 108.119 108.119 0 0.000%
immutable 184.001 183.998 -0.003 -0.002%
inner_html 83.808 83.806 -0.002 -0.002%
js_callback 113.005 113.006 +0.001 +0.001%
keyed_list 197.809 197.810 +0.001 +0.000%
mount_point 86.957 86.958 +0.001 +0.001%
nested_list 114.944 114.940 -0.004 -0.003%
node_refs 94.873 94.873 0 0.000%
password_strength 1553.073 1553.070 -0.003 -0.000%
portals 98.146 98.146 -0.001 -0.001%
router 320.016 320.021 +0.006 +0.002%
simple_ssr 153.054 153.050 -0.004 -0.003%
ssr_router 394.403 394.396 -0.008 -0.002%
suspense 110.617 110.618 +0.001 +0.001%
timer 90.257 90.255 -0.002 -0.002%
todomvc 142.749 142.749 0 0.000%
two_apps 88.017 88.015 -0.002 -0.002%
web_worker_fib 154.384 154.384 0 0.000%
webgl 86.507 86.508 +0.001 +0.001%

✅ None of the examples has changed their size significantly.

Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not aware of any way to run these actions locally. Generally they're tested in PRs but the post-* actions can't be tested without merging because they're picked from master

@WorldSEnder WorldSEnder merged commit 6160703 into yewstack:master Dec 17, 2022
@WorldSEnder WorldSEnder deleted the fix-benchmark branch December 17, 2022 15:09
@WorldSEnder WorldSEnder added A-tools Area: Tools such as trunk, wasm-bindgen A-ci Area: The continuous integration and removed A-tools Area: Tools such as trunk, wasm-bindgen labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: The continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants