Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement an internal DomSlot for positioning instead of NodeRef #3048

Merged
merged 22 commits into from
Jan 9, 2023
Merged

Implement an internal DomSlot for positioning instead of NodeRef #3048

merged 22 commits into from
Jan 9, 2023

Commits on Dec 17, 2022

  1. implement internal DomPosition 

    use instead of NodeRef, decoupling the two
fixes yewstack#3043
    @WorldSEnder
    WorldSEnder committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    d9b2d66 View commit details
    Browse the repository at this point in the history

  2. remove a debug log, and fix feature soundness

    @WorldSEnder
    WorldSEnder committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    02bd1cd View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2023

  1. move DomPosition into submodule

    @WorldSEnder
    WorldSEnder committed Jan 1, 2023
    Configuration menu
    Copy the full SHA
    a219868 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2023

  1. rename DomPosition::new -> DomPosition::at 

    this is more consistent with DomPosition::at_end
    @WorldSEnder
    WorldSEnder committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    ce1a3d3 View commit details
    Browse the repository at this point in the history

  2. hide behind feature csr

    @WorldSEnder
    WorldSEnder committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    ef4a009 View commit details
    Browse the repository at this point in the history

  3. move DomPosition into dom_bundle

    @WorldSEnder
    WorldSEnder committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    73d513f View commit details
    Browse the repository at this point in the history

  4. add documentation

    @WorldSEnder
    WorldSEnder committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    60aa5df View commit details
    Browse the repository at this point in the history

  5. move get to RetargetableDomPosition

    @WorldSEnder
    WorldSEnder committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    9622a22 View commit details
    Browse the repository at this point in the history

  6. fix clippy warning

    @WorldSEnder
    WorldSEnder committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    4ad3f42 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. add test cases

    @WorldSEnder
    WorldSEnder committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    f0a1129 View commit details
    Browse the repository at this point in the history

  2. make insert a method on DomPosition

    @WorldSEnder
    WorldSEnder committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    53b63c7 View commit details
    Browse the repository at this point in the history

  3. use DomPosition::insert

    @WorldSEnder
    WorldSEnder committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    0e5d3db View commit details
    Browse the repository at this point in the history

  4. rename next_sibling -> slot

    @WorldSEnder
    WorldSEnder committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    e1d481a View commit details
    Browse the repository at this point in the history

  5. rename DomPosition -> DomSlot according to review

    @WorldSEnder
    WorldSEnder committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    48b4623 View commit details
    Browse the repository at this point in the history

  6. private DomSlot::get

    @WorldSEnder
    WorldSEnder committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    83abc9a View commit details
    Browse the repository at this point in the history

  7. write get in continuation style, this saves a clone

    @WorldSEnder
    WorldSEnder committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    ad42b25 View commit details
    Browse the repository at this point in the history

  8. rename as_position -> to_position

    @WorldSEnder
    WorldSEnder committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    3307907 View commit details
    Browse the repository at this point in the history

  9. rename RetargetableDomSlot -> DynamicDomSlot

    @WorldSEnder
    WorldSEnder committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    415307b View commit details
    Browse the repository at this point in the history

  10. Improve documentation

    @WorldSEnder
    WorldSEnder committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    f614226 View commit details
    Browse the repository at this point in the history

  11. more docs, fix unintentional size increase

    @WorldSEnder
    WorldSEnder committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    02fa16a View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. address review 

    rename retarget -> reassign
    @WorldSEnder
    WorldSEnder committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    66a0d55 View commit details
    Browse the repository at this point in the history

  2. rename module dom_position -> position 

    also add module doc
    @WorldSEnder
    WorldSEnder committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    3265656 View commit details
    Browse the repository at this point in the history