-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare yew 0.20.1 patch release #3086
Prepare yew 0.20.1 patch release #3086
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About time we release a patch release
CHANGELOG.md
Outdated
- Make Classes cheap to clone. [[@Cecile Tonglet](https://github.com/Cecile Tonglet), [#3021](https://github.com/yewstack/yew/pull/3021)] | ||
- Implement an internal DomSlot for positioning instead of NodeRef. [[@WorldSEnder](https://github.com/WorldSEnder), [#3048](https://github.com/yewstack/yew/pull/3048)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should probably go in fixes but I'm fine with it either way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should cherry-pick changes that we wish to release than releasing it from master branch directly as patch releases should not contain public API changes.
8edd55d
to
a36bab6
Compare
a36bab6
to
2a25243
Compare
Retargeting this to the feature branch. @hamza1311 do you know if it would work if I just executed the publish action from the branch? We really shouldn't include the breaking change as pointed out by futursolo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will approve this pull request as the primary issue preventing merge is already addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WorldSEnder, yes the workflow will run just fine if it's used from a different branch. In fact, 0.20 was released not from master but from another branch
Can we get the gloo-history fix included as well? @hamza1311 knows what I mean. |
@simbleau, that was in a patch release so cargo should automatically resolve the latest version. Have you tried running |
Really dumb question: this was merged, but there is no 0.20.1 release. What happened? |
Description
Prepare for 0.20.1 patch release. This PR updates the change log. I'm not sure if a blog post is in order. This is targeting the performance regression observed in the
07_create10k
testcase of js-framework-benchmark and the connected bugs, #3024, #3043 as well as a regression in listeners #2989.