Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy for 1.67 #3100

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Fix clippy for 1.67 #3100

merged 2 commits into from
Feb 1, 2023

Conversation

futursolo
Copy link
Member

Description

This pull request fixes clippy errors for Rust 1.67

Checklist

  • I have reviewed my own code
  • I have added tests

github-actions[bot]
github-actions bot previously approved these changes Jan 30, 2023
@github-actions
Copy link

github-actions bot commented Jan 30, 2023

Visit the preview URL for this PR (updated for commit d21200a):

https://yew-rs-api--pr3100-fix-clippy-1-67-0xpm3nk5.web.app

(expires Mon, 06 Feb 2023 10:40:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Jan 30, 2023

Benchmark - SSR

Yew Master

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 393.201 393.707 393.400 0.159
Hello World 10 721.083 728.665 723.076 2.129
Function Router 10 2317.450 2337.696 2329.782 5.410
Concurrent Task 10 1007.237 1008.972 1008.481 0.495

Pull Request

Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 393.222 394.549 393.570 0.372
Hello World 10 709.438 716.914 711.722 2.562
Function Router 10 2393.879 2427.152 2402.779 9.848
Concurrent Task 10 1008.034 1009.383 1008.532 0.424

@github-actions
Copy link

github-actions bot commented Jan 30, 2023

Size Comparison

examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 107.873 107.873 0 0.000%
boids 170.760 170.767 +0.007 +0.004%
communication_child_to_parent 90.831 90.836 +0.005 +0.005%
communication_grandchild_with_grandparent 105.160 105.164 +0.004 +0.004%
communication_grandparent_to_grandchild 100.996 100.998 +0.002 +0.002%
communication_parent_to_child 87.927 87.932 +0.005 +0.006%
contexts 107.707 107.705 -0.002 -0.002%
counter 85.731 85.732 +0.001 +0.001%
counter_functional 86.043 86.044 +0.001 +0.001%
dyn_create_destroy_apps 88.512 88.513 +0.001 +0.001%
file_upload 100.191 100.193 +0.002 +0.002%
function_memory_game 164.879 164.874 -0.005 -0.003%
function_router 349.516 349.524 +0.009 +0.003%
function_todomvc 159.861 159.867 +0.006 +0.004%
futures 224.483 224.483 0 0.000%
game_of_life 106.489 106.490 +0.001 +0.001%
immutable 181.965 181.961 -0.004 -0.002%
inner_html 82.121 82.120 -0.001 -0.001%
js_callback 111.943 111.948 +0.005 +0.004%
keyed_list 196.188 196.198 +0.011 +0.005%
mount_point 85.359 85.359 0 0.000%
nested_list 113.392 113.396 +0.004 +0.003%
node_refs 93.370 93.377 +0.007 +0.007%
password_strength 1549.274 1549.274 0 0.000%
portals 96.562 96.562 +0.001 +0.001%
router 319.671 319.689 +0.019 +0.006%
simple_ssr 150.976 150.977 +0.001 +0.001%
ssr_router 394.699 394.702 +0.003 +0.001%
suspense 109.074 109.074 0 0.000%
timer 88.608 88.606 -0.002 -0.002%
todomvc 141.098 141.100 +0.002 +0.001%
two_apps 86.353 86.353 0 0.000%
web_worker_fib 151.895 151.909 +0.015 +0.010%
webgl 84.909 84.907 -0.002 -0.002%

✅ None of the examples has changed their size significantly.

@futursolo
Copy link
Member Author

The failures in benchmark is not related.

@ranile ranile merged commit 456a05b into yewstack:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants