Add resize service #577
Merged
Add resize service #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
requested changes
Aug 11, 2019
…dd doc comments, add window dimensions when the callback is called
jstarry
approved these changes
Aug 11, 2019
|
Sorry about that, I've had this service lying around for the greater part of a year and I just copied+pasted them into Yew without doing a proper check first. Coding before coffee leads to these mistakes 😄. |
|
Haha no worries, thanks for addressing the feedback with lightning speed 👍 |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 11, 2019
577: Add resize service r=jstarry a=hgzimmerman Adds a service to handle resize events. Implementation as loosely dictated by #541. If you want to make this a full-blown window service instead of just focusing on resizes, let me know the other events this service should handle and I'll try to add them. Co-authored-by: Henry Zimmerman <zimhen7@gmail.com>
Build succeeded
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a service to handle resize events.
Implementation as loosely dictated by #541.
If you want to make this a full-blown window service instead of just focusing on resizes, let me know the other events this service should handle and I'll try to add them.