Remove allocation in vtag diff #591
Conversation
|
Awesome, thanks @tafia, I'll run some benchmarks and see what the improvements are! |
There was a problem hiding this comment.
Unfortunately, there wasn't any movement on the benchmark numbers but this is still a great change! I also would have expected this to improve performance though, not sure why :/ I hope to add some automated benchmarking soon which will make it easier to fight this battle :)
After making the changes, can you please rebase to remove the fmt changes you picked up in src/html? Thanks!
|
I've applied the suggestions. I am a bit surprised that there is no impact, sorry for having you lose your time! |
|
Note that I haven't put the I can put it there if needed. |
|
No worries at all! Happy for your contribution and would gladly accept more PRs like this one. Sorry for the slow review, looks great!! |
|
bors r+ |
591: Remove allocation in vtag diff r=jstarry a=tafia **Disclaimer**: I couldn't test it on my system yet. This PR attempts to remove all allocations (`String`, `Vec` and `HashSet`) used in various vtag diff functions. I believe this should have an impact both in terms of performance and memory. Co-authored-by: Johann Tuffe <tafia973@gmail.com>
Build succeeded
|
Trust me I am much slower nowadays! |
Disclaimer: I couldn't test it on my system yet.
This PR attempts to remove all allocations (
String,VecandHashSet) used in various vtag diff functions.I believe this should have an impact both in terms of performance and memory.