Add Dispatchers #639

hgzimmerman · 2019-09-14T16:31:19Z

Addresses #307

Dispatchers are similar to bridges, but they don't require a callback to instantiate.

Dispatchers solve the problem of having to create NoOp messages that handle responses from Agents for components that do not care about them. This is a relatively common occurrence, and this change provides a significant ergonomic improvement over handling these NoOp cases.

Dispatchers, when created, will not hook into the typical Component <-> Agent lifecycle. This is because they do not have HandlerIds. So connected and disconnected will not be called when Agent::dispatcher() is called. You can send messages through them, which still reach the handle method on the Agent.

Because of the lack of HandlerIds in dispatchers, a breaking change was required for Agent::handle which now takes an Option<HandlerId> instead of just a HandlerId.

Because it would be pointless to have dispatchers to Job and Private discoverers, its usage is constrained to just Context and Public discoverers.

… to create; updated router example

hgzimmerman

Not exactly sure what I'm doing w/ SINGLETON_ID here, and I don't replicate it for Private discoverers.
It should be neither or both.

src/agent.rs

hgzimmerman · 2019-09-14T18:11:00Z

@jstarry It looks to me like the CI is acting funky (although because of the breaking change, I still probably broke another example, but its failing for what appears to be unrelated reasons)

jstarry

Definitely understand the motivation for this, seems like a nice ergonomic improvement to me. I would like to avoid making a breaking change for the optional handler id, let me know your thoughts! I also made a change to remove some code reuse here: hgzimmerman#1

src/agent.rs

examples/routing/src/router_button.rs

examples/routing/src/lib.rs

Avoid code reuse in agents

hgzimmerman · 2019-09-24T23:25:06Z

I still need to address the singleton id stuff, but I have merged your suggestions into this branch.
I added a new-type around Box<dyn Bridge> because I think the different behavior warrants a distinct type. Let me know what you think about that.

jstarry

Looks like 44aeb47 isn't quite right, can you fix?

Also, I think I have a good solution for HandlerId:

Always insert into slab, whether Callback is Some or None
Change type of slab to accept Option<Callback>
Change HandlerId to (usize, bool)
Add is_respondable() method to HandlerId

src/agent.rs

hgzimmerman · 2019-09-25T13:54:17Z

Not sure if this is completely done, but I'm sure it gets us closer to the implementation we want. Let me know if there is anything else that needs changing.

src/agent.rs

jstarry

Add specific warning message if Agent tries to send message to handler with no callback

examples/routing/src/lib.rs

jstarry

Looks great! There isn't a breaking change anymore, right?

hgzimmerman · 2019-09-25T18:37:27Z

Yes, I no longer think that this breaks anything.

* Add Dispatchers, which act like bridges, but don't require a callback to create; updated router example * cargo fmt * improve comment * Another approach * add newtype around dispatcher bridges * added debug impl, run cargo fmt * fix example * make button on routing example start on loading variant * revert singleton_id changes * actually revert singleton_id changes * slabs own option<callback> * cargo fmt * remove dead lines * address bad doc comment * fix router example * fix handler id initialization in local agent * add appropriate error message when id is not associated with callback * remove misleading comment * use a type alias to the shared output slab

hgzimmerman added 2 commits September 14, 2019 12:20

Add Dispatchers, which act like bridges, but don't require a callback…

12ce09b

… to create; updated router example

cargo fmt

436d62a

hgzimmerman commented Sep 14, 2019

View reviewed changes

src/agent.rs Outdated Show resolved Hide resolved

src/agent.rs Outdated Show resolved Hide resolved

hgzimmerman mentioned this pull request Sep 21, 2019

Move route_agent to its own directory module yewstack/yew_router#44

Merged

improve comment

206aa4b

jstarry added the breaking change label Sep 23, 2019

jstarry changed the title ~~Add Dispatchers [Breaking Change]~~ Add Dispatchers Sep 23, 2019

Another approach

ae8de8a

jstarry reviewed Sep 23, 2019

View reviewed changes

src/agent.rs Outdated Show resolved Hide resolved

src/agent.rs Outdated Show resolved Hide resolved

examples/routing/src/router_button.rs Show resolved Hide resolved

examples/routing/src/lib.rs Outdated Show resolved Hide resolved

jstarry added the ergonomics label Sep 23, 2019

hgzimmerman and others added 3 commits September 24, 2019 19:03

Merge pull request #1 from jstarry/pr/639

87fa037

Avoid code reuse in agents

add newtype around dispatcher bridges

7e5d7b5

added debug impl, run cargo fmt

4086c73

hgzimmerman added 3 commits September 24, 2019 19:33

fix example

5b9167e

make button on routing example start on loading variant

3f75513

revert singleton_id changes

44aeb47

hgzimmerman requested a review from jstarry September 25, 2019 00:31

jstarry requested changes Sep 25, 2019

View reviewed changes

src/agent.rs Outdated Show resolved Hide resolved

hgzimmerman added 2 commits September 24, 2019 23:00

actually revert singleton_id changes

6e072c2

merge with master

3f05bfc

hgzimmerman added 5 commits September 25, 2019 09:41

slabs own option<callback>

bff1b66

cargo fmt

7f531f1

remove dead lines

3fabaf9

address bad doc comment

f40c9c5

fix router example

e758bd1

hgzimmerman requested a review from jstarry September 25, 2019 13:54

fix handler id initialization in local agent

e885a3f

jstarry reviewed Sep 25, 2019

View reviewed changes

src/agent.rs Outdated Show resolved Hide resolved

jstarry requested changes Sep 25, 2019

View reviewed changes

jstarry reviewed Sep 25, 2019

View reviewed changes

examples/routing/src/lib.rs Outdated Show resolved Hide resolved

hgzimmerman added 3 commits September 25, 2019 12:22

add appropriate error message when id is not associated with callback

c35c6e0

remove misleading comment

6ba092e

use a type alias to the shared output slab

869a25f

hgzimmerman requested a review from jstarry September 25, 2019 17:55

jstarry approved these changes Sep 25, 2019

View reviewed changes

hgzimmerman mentioned this pull request Sep 25, 2019

Experiment: Agent-based Directional Message Passing #301

Closed

jstarry removed the breaking change label Sep 26, 2019

jstarry merged commit 97f5aa3 into yewstack:master Sep 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Dispatchers #639

Add Dispatchers #639

hgzimmerman commented Sep 14, 2019 •

edited

Loading

hgzimmerman left a comment

hgzimmerman commented Sep 14, 2019 •

edited

Loading

jstarry left a comment

hgzimmerman commented Sep 24, 2019

jstarry left a comment

hgzimmerman commented Sep 25, 2019

jstarry left a comment

jstarry left a comment

hgzimmerman commented Sep 25, 2019

Add Dispatchers #639

Add Dispatchers #639

Conversation

hgzimmerman commented Sep 14, 2019 • edited Loading

hgzimmerman left a comment

Choose a reason for hiding this comment

hgzimmerman commented Sep 14, 2019 • edited Loading

jstarry left a comment

Choose a reason for hiding this comment

hgzimmerman commented Sep 24, 2019

jstarry left a comment

Choose a reason for hiding this comment

hgzimmerman commented Sep 25, 2019

jstarry left a comment

Choose a reason for hiding this comment

jstarry left a comment

Choose a reason for hiding this comment

hgzimmerman commented Sep 25, 2019

hgzimmerman commented Sep 14, 2019 •

edited

Loading

hgzimmerman commented Sep 14, 2019 •

edited

Loading