Fix VNode orphaning inside of VTags #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, what a bad bug! Thank you so much @hgzimmerman for tracking this down! |
jstarry
approved these changes
Sep 22, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 23, 2019
651: Fix VNode orphaning inside of VTags r=jstarry a=hgzimmerman Fixes #643 VTags now recursively detach their children when they are detached themselves. This means that Components nested within `<div>`s or other elements will now properly run their `destroy` function and be dropped by the framework. Its nice to finally squash a bug that's bothered me for more than a year. Co-authored-by: Henry Zimmerman <zimhen7@gmail.com>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #643
VTags now recursively detach their children when they are detached themselves. This means that Components nested within
<div>s or other elements will now properly run theirdestroyfunction and be dropped by the framework.Its nice to finally squash a bug that's bothered me for more than a year.