Fix diff for VText nodes #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
added a commit
that referenced
this pull request
Oct 13, 2019
hgzimmerman
pushed a commit
to hgzimmerman/yew
that referenced
this pull request
Oct 14, 2019
llebout
pushed a commit
to llebout/yew
that referenced
this pull request
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #668
Problem
VTextnodes are always appended to the parent element. This is bad because sometimes the text node should be inserted in the middle of the parent element's children.Solution
Insert text nodes after
previous_siblingif it exists