Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename methods and loosen mutability for component link and agent #780

Merged
merged 3 commits into from
Dec 7, 2019
Merged

Rename methods and loosen mutability for component link and agent #780

merged 3 commits into from
Dec 7, 2019

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Dec 7, 2019

Problem

Callback creation is unintuitive. The API is not very clear and it's not possible to create callbacks in Component::view

Solution

  • Rename send_back to callback
  • Rename send_self to send_message
  • Loosen mutability restriction for callback creation

@jstarry jstarry merged commit ffbb9e0 into yewstack:master Dec 7, 2019
@jstarry jstarry deleted the view-callback branch December 7, 2019 23:18
llebout pushed a commit to llebout/yew that referenced this pull request Jan 20, 2020
@jstarry @llebout
Rename methods and loosen mutability for component link and agent (ye…
3565288 
…wstack#780)

* Rename methods and loosen mutability for component link and agent

* Update send_back to callback

* mut link -> link
@jstarry jstarry mentioned this pull request Feb 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jstarry