Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove send_future from ComponentLink #799

Merged
merged 3 commits into from
Dec 10, 2019

Conversation

hgzimmerman
Copy link
Member

Closes #792

This also removes the futures example.

Here is where the futures example is migrating to: yewstack/yewtil#37
And send_future now exists here: https://github.com/yewstack/yewtil/blob/596844663be16162f0bbd2f98d36f41b70096adf/src/future.rs#L7

@jstarry
Copy link
Member

jstarry commented Dec 10, 2019

I think we should keep the example here too. It's not necessary to use yewtil to use futures

@hgzimmerman
Copy link
Member Author

Understood. I'll reinstate the example and provide an implementation of send_future within it.

There is the question of #776 though. I think in the meantime, I'll implement it in yewtil and copy the stdweb-compatible implementation of it to the futures example here later?

@jstarry jstarry merged commit 5d97142 into yewstack:master Dec 10, 2019
@jstarry
Copy link
Member

jstarry commented Dec 10, 2019

Thanks! That's just what I had in mind.

RE #776, sounds good!

llebout pushed a commit to llebout/yew that referenced this pull request Jan 20, 2020
* remove send_future from ComponentLink

* Revert "remove send_future from ComponentLink"

This reverts commit c1b1ad4.

* remove send_future, reimplement it in the futures example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

send_future is no longer needed
2 participants