Allow binary-only formats (e.g., CBOR) with websockets #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the various formats that can't be converted in or out of Text to be used in the callback that a websocket will use. It also supports the packed version of CBOR.
|
Thanks @ctm! I think I would prefer to solve the root issue though. WebSocket should allow binary only formats as well as binary + text formats. Would you be interested in tackling that? It would require some api changes to websocket Your CBORPacked changes look fine, could you please update (and rebase to fix ci) this PR to only have those changes and then move websocket changes to a follow up PR? |
|
@jstarry I'll go ahead and get a CborPacked only PR done this evening and then look into a binary only WebSocket. I'm pretty new to WebSockets, but I'll see if I can pull together a solution to the root issue tomorrow. |
|
Closing per above. My CborPacked PR is #849 |
jstarry
changed the title
llebout
pushed a commit
to llebout/yew
that referenced
this pull request
Jan 20, 2020
…yewstack#847) This allows the various formats that can't be converted in or out of Text to be used in the callback that a websocket will use. It also supports the packed version of CBOR. Co-authored-by: Justin Starry <justin.m.starry@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #389
This allows the various formats that can't be converted in or out of Text to be used in the callback that a websocket will use.