Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from failure to anyhow and thiserror. #863

Merged
merged 4 commits into from
Jan 15, 2020
Merged

Switch from failure to anyhow and thiserror. #863

merged 4 commits into from
Jan 15, 2020

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Jan 9, 2020

Fixes #861.

@jstarry
Copy link
Member

jstarry commented Jan 11, 2020

@daxpedda great! How about merging this into master instead of web-sys?

@daxpedda daxpedda changed the base branch from web-sys to master January 11, 2020 16:06
@daxpedda
Copy link
Contributor Author

@daxpedda great! How about merging this into master instead of web-sys?

Will rebase when I'm back home.

@daxpedda
Copy link
Contributor Author

Done.

jstarry
jstarry reviewed Jan 15, 2020
View reviewed changes
Copy link
Member

@jstarry jstarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Will merge after these minor comments are addressed

examples/dashboard/.vscode/settings.json Outdated Show resolved Hide resolved
examples/npm_and_rest/src/gravatar.rs Outdated Show resolved Hide resolved
@jstarry jstarry merged commit 1f4c415 into yewstack:master Jan 15, 2020
llebout pushed a commit to llebout/yew that referenced this pull request Jan 20, 2020
@daxpedda @llebout
Switch from failure to anyhow and thiserror. (yewstack#863)
1f8319c 
* Switch to `anyhow` and `thiserror`.

* Fix doc tests.

* Fix fmt.

* Some polish.
@jplatte jplatte mentioned this pull request Feb 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstarry jstarry jstarry left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch from failure to anyhow and thiserror.
2 participants
@daxpedda @jstarry