Improve html! "for" iterable ergonomics #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Jan 15, 2020
| @@ -41,8 +41,7 @@ impl ToTokens for HtmlIterable { | |||
| let expr = &self.0; | |||
| let new_tokens = quote_spanned! {expr.span()=> { | |||
| let mut __yew_vlist = ::yew::virtual_dom::VList::default(); | |||
| let __yew_nodes: &mut ::std::iter::Iterator<Item = _> = &mut(#expr); | |||
| for __yew_node in __yew_nodes.into_iter() { | |||
| for __yew_node in ::std::iter::IntoIterator::into_iter(#expr) { | |||
There was a problem hiding this comment.
If you're using it directly in a for loop, the call to into_iter is redundant, as that's already what for does internally (documented here).
Suggested change
| for __yew_node in ::std::iter::IntoIterator::into_iter(#expr) { | |
| for __yew_node in #expr { |
|
Works as expected! |
llebout
pushed a commit
to llebout/yew
that referenced
this pull request
Jan 20, 2020
* Improve html! iteratable ergonomics * feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #871
Problem
Poor ergonomics when using
html! { for .. }. When passing a local variable into html! as part of { for my_var }, it is an error for that local variable not to be mut.Solution
Use std::iter::IntoIterator::into_iter(#expr) as suggested by @jplatte