Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ResizeTask drop #915

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Fix ResizeTask drop #915

merged 1 commit into from
Feb 3, 2020

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Feb 2, 2020

Fixes #904

Problem

The Drop method would always fail because handle was undefined

Solution

  • Properly return the callback so that it can be dropped
  • Remove the resize listener on drop

@jstarry jstarry merged commit ee4792c into yewstack:master Feb 3, 2020
@jstarry jstarry deleted the fix-resize branch February 3, 2020 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error dropping ReziseTask when going back a page with Yew Router
1 participant
@jstarry