Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link all outstanding TODO items to a ticket #949

Merged
merged 1 commit into from
Feb 15, 2020

Conversation

bacongobbler
Copy link
Contributor

closes #800

Note: as pointed out in #800, report_todo and report_fixme are only available on the nightly channel. If you're on the stable channel, you will see a ton of error messages any time you run cargo fmt. Perhaps these should be commented out? Let me know how you'd like to proceed here.

><> rustup default stable
info: using existing install for 'stable-x86_64-apple-darwin'
info: default toolchain set to 'stable-x86_64-apple-darwin'

  stable-x86_64-apple-darwin unchanged - rustc 1.41.0 (5e1a79984 2020-01-27)

><> cargo fmt
Warning: can't set `report_todo = Unnumbered`, unstable features are only available in nightly channel.
Warning: can't set `report_fixme = Unnumbered`, unstable features are only available in nightly channel.
Warning: can't set `report_todo = Unnumbered`, unstable features are only available in nightly channel.
Warning: can't set `report_fixme = Unnumbered`, unstable features are only available in nightly channel.
Warning: can't set `report_todo = Unnumbered`, unstable features are only available in nightly channel.
Warning: can't set `report_fixme = Unnumbered`, unstable features are only available in nightly channel.
Warning: can't set `report_todo = Unnumbered`, unstable features are only available in nightly channel.
Warning: can't set `report_fixme = Unnumbered`, unstable features are only available in nightly channel.
Warning: can't set `report_todo = Unnumbered`, unstable features are only available in nightly channel.
Warning: can't set `report_fixme = Unnumbered`, unstable features are only available in nightly channel.

Signed-off-by: Matthew Fisher matt.fisher@microsoft.com

Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
@jstarry
Copy link
Member

jstarry commented Feb 15, 2020

I'm fine with the warnings, thanks so much for doing this!

@jstarry jstarry merged commit df14a9f into yewstack:master Feb 15, 2020
@bacongobbler bacongobbler deleted the fix-800 branch February 15, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an Issue for every outstanding // TODO
2 participants