Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix agent borrow mut panic #981

Merged
merged 1 commit into from
Mar 1, 2020
Merged

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Mar 1, 2020

Fixes #679

Problem

Borrow locks are held until dropped and so a lock was mistakenly held too long

Changes

  • Make borrow locks more explicit by binding to local variables
  • Fix borrow mut panic by wrapping callback lookup in a closure
  • Refactor bridge dropping to eliminate a borrow_mut call

@jstarry jstarry merged commit c991c7c into yewstack:master Mar 1, 2020
@jstarry jstarry deleted the fix-agent-panic branch March 1, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic error message: already borrowed: BorrowMutError
1 participant