This repository has been archived by the owner on Jul 19, 2020. It is now read-only.
Relax capture rules in Fragment sections in route syntax parser #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #193
Partially fixes #197
What this change does is allow the following syntax to be valid:
#{*:field}or#{3:field}, whereas before, only#{field}was valid.The other possibility instead of this PR is to make
#{field}produce the same tokens as#{*:field}when used in a fragment context, but I think its easier for users to not have to deal with a context-sensitive rules about what can be parsed.For now, this change doesn't make changes to the parser's state machine - in the future, the Fragment state may be modified to allow backtracking to prior states in some form.