Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update FAQ #26

Merged
merged 2 commits into from
Aug 27, 2022
Merged

docs: Update FAQ #26

merged 2 commits into from
Aug 27, 2022

Conversation

iron3oxide
Copy link
Contributor

Fix indentation, grammar and some wording. Correct some factual claims or make them more precise (e.g. engine vs. connection string)

Fix indentation, grammar and some wording. Correct some factual claims or make them more precise (e.g. engine vs. connection string)
@netlify
Copy link

netlify bot commented Aug 27, 2022

Deploy Preview for radiant-parfait-6207eb ready!

Name Link
🔨 Latest commit ec43e44
🔍 Latest deploy log https://app.netlify.com/sites/radiant-parfait-6207eb/deploys/630a7bf15f9ff5000ab6fb66
😎 Deploy Preview https://deploy-preview-26--radiant-parfait-6207eb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@iron3oxide
Copy link
Contributor Author

iron3oxide commented Aug 27, 2022

I don't know why the lint check failed. Maybe I have to specify python3 instead of python in the code blocks? But then again #23 shouldn't have worked..

EDIT: it's something about trailing whitespace

@yezz123
Copy link
Owner

yezz123 commented Aug 27, 2022

I don't know why the lint check failed. Maybe I have to specify python3 instead of python in the code blocks? But then again #23 shouldn't have worked..

EDIT: it's something about trailing whitespace

I will fix it its related to pre-commit i guess you didn't run bash scripts/format.sh

@iron3oxide
Copy link
Contributor Author

I didn't even set up a venv or anything, I thought making documentation changes wouldn't require it. Seems I underestimated the depth these linters crawl through..

@yezz123 yezz123 merged commit 56b08f7 into yezz123:main Aug 27, 2022
@yezz123
Copy link
Owner

yezz123 commented Aug 27, 2022

Thank you @iron3oxide 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants