Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move constants to separate file #212

Merged

Conversation

jbienkowski311
Copy link
Contributor

Description

Moves constants to separate file. Now one can import only constants if needed.

Motivation and Context

Implements #205

How Has This Been Tested?

npm test - all green

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@DavidVujic DavidVujic self-requested a review August 11, 2019 19:47
README.md Show resolved Hide resolved
examples/wrapper.js Outdated Show resolved Hide resolved
examples/wrapper.js Outdated Show resolved Hide resolved
@DavidVujic DavidVujic merged commit 814daa6 into yfinkelstein:master Aug 14, 2019
@jbienkowski311 jbienkowski311 deleted the feature/separate-constants branch August 14, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants