Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug "expected 3 arguments" #230

Merged
merged 3 commits into from
Dec 9, 2019
Merged

fix bug "expected 3 arguments" #230

merged 3 commits into from
Dec 9, 2019

Conversation

wareczek
Copy link
Contributor

@wareczek wareczek commented Dec 6, 2019

Fix bug in method "add_auth".

Error: expected 3 arguments

@wareczek
Copy link
Contributor Author

wareczek commented Dec 6, 2019

fixes #194

@wareczek
Copy link
Contributor Author

wareczek commented Dec 6, 2019

@DavidVujic please merge & release asap :)

@DavidVujic DavidVujic self-requested a review December 7, 2019 11:45
Copy link
Collaborator

@DavidVujic DavidVujic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @wareczek!

Can you also add a unit test (if possible), or example code that will show the effects of the currently missing parameter?

@DavidVujic DavidVujic merged commit 60b656d into yfinkelstein:master Dec 9, 2019
@wareczek wareczek deleted the expected-3-arguments branch December 9, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants