Use ZooKeeper C Client v3.5.8 in all platforms #260
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When installing this package on Windows, an old version of the C client (3.4.12) is used because of issues related to #222
With v3.5.8 used in this PR, the issues for Windows are resolved and it is possible to build an addon from the same source code.
In addition to that, the no longer needed install scripts are removed and new prebuilds for Mac OS X and Windows are packaged.
One more thing: the ZooKeeper source code is slimmed down to only including the C client code. The package has been pre-configured using
ant
andautoreconf
- so there is no need for the patching (copying of autoconf generated files in thepatches
folder) that previously had to be done. This will result in a much lighter npm package (currently 5 MB). 🎉Motivation and Context
With this setup, adding features will be a whole lot easier.
How Has This Been Tested?
Travis CI build OK
Tested manually by running a local Zookeeper server and start a client by running
node examples/index.js
in Linux, Mac OS X and Windows 10.Tested with ZooKeeper server 3.4.8 (the one that was causing issues) and the latest version.
Types of changes
Checklist: