Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong type for watch param - should be boolean #266

Merged
merged 2 commits into from
Feb 18, 2021
Merged

fix: wrong type for watch param - should be boolean #266

merged 2 commits into from
Feb 18, 2021

Conversation

DavidVujic
Copy link
Collaborator

Fixes #257

@DavidVujic DavidVujic merged commit 98e09a6 into yfinkelstein:master Feb 18, 2021
@DavidVujic DavidVujic deleted the code-docs-for-exist-function branch February 18, 2021 19:10
@jbienkowski311
Copy link
Contributor

@DavidVujic you missed one spot in TS declarations: https://github.com/yfinkelstein/node-zookeeper/pull/266/files#diff-ba2cb7b5b9902d2bfdb1b817dec726392fa72ed9504cbfda67344d353a75891dR469

@DavidVujic
Copy link
Collaborator Author

Oh no! 😄 I'll have a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code docs: boolean, not function (exists function)
2 participants
@DavidVujic @jbienkowski311