Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace existing integration tests (scripts) with new ones (using Ava). #297

Merged

Conversation

DavidVujic
Copy link
Collaborator

@DavidVujic DavidVujic commented Jan 8, 2022

The goal is to run the integration tests in a Docker environment, and get proper test results.

Description

Replacing the existing test scripts with new ones using a test tool (ava).

Motivation and Context

The existing integration test scripts are difficult to understand if they have succeeded or failed. Some of them seems to have transient behaviour. This is an attempt to formalize the tests into "proper" ones using a test tool (ava) with assertions.

Long term, I want to run these integration tests in CircleCI (using Docker/Docker compose).

How Has This Been Tested?

npm test ✅
npm run lint ✅
npm run test-integration ✅
CircleCI ✅

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@DavidVujic DavidVujic marked this pull request as ready for review January 8, 2022 13:46
@DavidVujic DavidVujic changed the title WIP: Replace existing integration tests (scripts) with new ones (using Ava). Replace existing integration tests (scripts) with new ones (using Ava). Jan 8, 2022
@DavidVujic DavidVujic merged commit 9ba5166 into yfinkelstein:master Jan 8, 2022
@DavidVujic DavidVujic deleted the integration_tests_cleanup branch January 8, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant