Skip to content

Commit

Permalink
Fix problems with SSLSlientServerTest.* tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@yhirose
yhirose committed Sep 17, 2024
1 parent 5064373 commit 4990b4b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/Makefile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ cert.pem:
openssl req -new -batch -config test.conf -key key.pem | openssl x509 -days 3650 -req -signkey key.pem > cert.pem
openssl req -x509 -config test.conf -key key.pem -sha256 -days 3650 -nodes -out cert2.pem -extensions SAN
openssl genrsa 2048 > rootCA.key.pem
openssl req -x509 -new -batch -config test.rootCA.conf -key rootCA.key.pem -days 1024 > rootCA.cert.pem
openssl req -x509v1 -new -batch -config test.rootCA.conf -key rootCA.key.pem -days 1024 > rootCA.cert.pem
openssl genrsa 2048 > client.key.pem
openssl req -new -batch -config test.conf -key client.key.pem | openssl x509 -days 370 -req -CA rootCA.cert.pem -CAkey rootCA.key.pem -CAcreateserial > client.cert.pem
openssl genrsa -passout pass:test123! 2048 > key_encrypted.pem
Expand Down

2 comments on commit 4990b4b

@Tachi107
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear this is not sufficient. As shown by the CI logs, OpenSSL versions older than 3.2 don't have the -x509v1 option, and will fail to generate the file. That's why in my Meson patch I conditionally pass -x509v1 or -x509 based on the detected openssl version.

@yhirose
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tachi107 yes, I noticed it, and made another commit c239087 to fix this issue.

Please sign in to comment.