Throw an error if inline result is not coercible to character #2007
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix #2006
as.character()
I wanted to indicate the line in the error message but it seems for inline code we don't actually get the location in the file I expected. So I just added the inline code that errors in the message. It is a start.
With this example
from the original issue in rmarkdown, we now get
Note that the lines indicated are not so useful because it is the all files. Contrary to code block, inline code are not exactly located on a line number.
Ideas from improvement for inline code chunk:
First line above is from all code proccessing (block an inline).
Second block is from inline execution only.
Anyway, this could be for another time
Also, I added unit test for this and a NEWS item as Major Changes as potential breaking change