Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change property Schema::$typeMap to constant Schema::TYPE_MAP #286

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 16, 2023

The change reduces size of cache.

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Nov 16, 2023

PR Summary

  • Introduction of Enhanced Consistency
    A new constant named TYPE_MAP has been introduced in the Schema class, enhancing predictability and consistency. An existing property typeMap has now been restricted for private access only, safeguarding it from unintended modifications.

  • Refining References
    The existing references to the typeMap property have been updated. They now utilize the constant TYPE_MAP, reducing the risk of errors by guaranteeing stable values.

  • Improved Method Implementation
    The loadColumnSchema method has been enhanced. It employs the constant TYPE_MAP when establishing the column type, ensuring accurate type mapping and improving the reliability of schema loading operation.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (907f8e5) 98.48% compared to head (1ca28a8) 98.48%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #286   +/-   ##
=========================================
  Coverage     98.48%   98.48%           
  Complexity      205      205           
=========================================
  Files            15       15           
  Lines           596      596           
=========================================
  Hits            587      587           
  Misses            9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov added the status:code review The pull request needs review. label Nov 16, 2023
@vjik vjik merged commit 5276702 into master Nov 16, 2023
21 checks passed
@vjik vjik deleted the change-typemap-to-constant branch November 16, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants