Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve deprecated methods #291

Merged
merged 5 commits into from
Feb 10, 2024
Merged

Resolve deprecated methods #291

merged 5 commits into from
Feb 10, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jan 29, 2024

Related with

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Jan 29, 2024

PR Summary

  • Refactoring use function array_map; handling in Schema file
    We've added functionality to use the array_map function which provides us with more streamlined ways to process and manipulate data arrays.

  • Improvement on indexing mechanism in loadTableIndexes() function
    The function definition has been changed to use array_map and array_change_key_case functions, simple coding changes that drastically improve the way we handle our indexes, leading to more reliable and efficient data operations.

  • Refactoring loadTableConstraints() function for better efficiency
    The modification changes how we handle constraint data by using array_map and array_change_key_case methods. This brings more accurate and efficient processing of the database constraints.

  • Modification to cache key generation in getCacheKey() function
    We've made improvements to our caching system by refining how we generate the cache key. The new method will strengthen the reliability of the cache system, ensuring that information is served more quickly and accurately.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff10686) 98.01% compared to head (150771f) 98.01%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #291   +/-   ##
=========================================
  Coverage     98.01%   98.01%           
  Complexity      208      208           
=========================================
  Files            15       15           
  Lines           604      604           
=========================================
  Hits            592      592           
  Misses           12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov added the status:code review The pull request needs review. label Jan 30, 2024
@Tigrov Tigrov merged commit f19738b into master Feb 10, 2024
36 of 38 checks passed
@Tigrov Tigrov deleted the deprecate-schema-methods branch February 10, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants