Remove ability to get service by Reference

yiisoft · Jul 14, 2020 · 970fce7 · 970fce7
1 parent 7251880
commit 970fce7
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 19 deletions.
diff --git a/src/Container.php b/src/Container.php
@@ -85,7 +85,6 @@ public function has($id): bool
      */
     public function get($id)
     {
-        $id = $this->getId($id);
         if (!isset($this->instances[$id])) {
             $this->instances[$id] = $this->build($id);
         }
@@ -191,11 +190,6 @@ private function validateDefinition($definition): void
         throw new InvalidConfigException('Invalid definition:' . var_export($definition, true));
     }
 
-    private function getId($id): string
-    {
-        return is_string($id) ? $id : $id->getId();
-    }
-
     /**
      * @param string $id
      *

diff --git a/tests/Unit/ContainerTest.php b/tests/Unit/ContainerTest.php
@@ -319,19 +319,6 @@ public function testReferencesInArrayInDependencies(): void
         $this->assertSame($container->get('engine4'), $moreEngines['more']['more']['engine4']);
     }
 
-    public function testGetByReference(): void
-    {
-        $container = new Container([
-            'engine' => EngineMarkOne::class,
-            'e1'     => Reference::to('engine'),
-        ]);
-        $one = $container->get(Reference::to('engine'));
-        $two = $container->get(Reference::to('e1'));
-        $this->assertInstanceOf(EngineMarkOne::class, $one);
-        $this->assertInstanceOf(EngineMarkOne::class, $two);
-        $this->assertSame($one, $two);
-    }
-
     public function testSameInstance(): void
     {
         $container = new Container([