Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to Add Reference::tag Method #333

Open
nahakyuu opened this issue Jul 19, 2023 · 4 comments
Open

Proposal to Add Reference::tag Method #333

nahakyuu opened this issue Jul 19, 2023 · 4 comments

Comments

@nahakyuu
Copy link

I propose adding a new method, Reference::tag

// before
Reference::to('tag@translation.categorySource');
Reference::to('tag@' . Yiisoft\Log\Target::class);
// after
Reference::tag('translation.categorySource');
Reference::tag(Yiisoft\Log\Target::class);
@xepozz
Copy link
Member

xepozz commented Jul 19, 2023

Would you like to implement?

@xepozz xepozz added the good first issue Simple enough issue to start with. label Jul 19, 2023
@vjik
Copy link
Member

vjik commented Jul 19, 2023

Tags is Yii DI feature only. This proposal should be implemented in yiisoft/di.

@vjik vjik transferred this issue from yiisoft/definitions Jul 19, 2023
@vjik vjik added status:under discussion and removed good first issue Simple enough issue to start with. labels Jul 19, 2023
@vjik
Copy link
Member

vjik commented Jul 19, 2023

Can we use one of exist class for implement suggested method or create new?

@BoShurik
Copy link

Maybe add a tag function which will use Reference::to('tag@'. $value);?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants