Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for symfony/console of version ^7.0 #189

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Add support for symfony/console of version ^7.0 #189

merged 1 commit into from
Dec 26, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Dec 26, 2023

Q A
Is bugfix?
New feature?
Breaks BC?

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab768b6) 96.86% compared to head (f59b50c) 96.86%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #189   +/-   ##
=========================================
  Coverage     96.86%   96.86%           
  Complexity       79       79           
=========================================
  Files             9        9           
  Lines           255      255           
=========================================
  Hits            247      247           
  Misses            8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Dec 26, 2023

PR Summary

  • Removed PHP Unit Watcher
    The unused .phpunit-watcher.yml file was deleted, streamlining the project structure.

  • Updated Log for New Enhancement
    The CHANGELOG.md file was updated to showcase a significant new enhancement that includes support for symfony/console version ^7.0.

  • Enhanced Dependencies in composer.json
    The composer.json file was revised to support symfony/console version ^7.0, thus bringing in the benefits of the latest Symfony features. Furthermore, the obsolete spatie/phpunit-watcher dependency was removed, boosting the overall project's performance.

  • Optimized Import Statements
    The src/Command/Game.php and src/Command/Serve.php files now include the use Symfony\Component\Console\Attribute\AsCommand statement, ensuring that the necessary Symfony command attributes can be used directly.

  • Refactored Game Command
    The src/Command/Game.php file's structure was refactored. Redundant $defaultName and $defaultDescription properties were removed and replaced by the #[AsCommand('|yii', 'A Guessing Game')] class annotation, thus improving code readability and maintainability.

  • Refactored Serve Command
    Likewise, the src/Command/Serve.php file was updated. By replacing the $defaultName and $defaultDescription properties with the #[AsCommand('serve', 'Runs PHP built-in web server')] class annotation, the code structure is now more straightforward and easy to manage.

  • Improved Testing Stub
    Changes were also made to the tests/Stub/ErrorCommand.php file. The $defaultName and $defaultDescription properties were discarded and replaced with the #[AsCommand('error', 'Error command tests')] class annotation, making the testing process significantly more accessible and efficient.

@vjik vjik added the status:code review The pull request needs review. label Dec 26, 2023
@vjik vjik requested a review from a team December 26, 2023 14:18
@vjik vjik merged commit 985fe5d into master Dec 26, 2023
26 of 28 checks passed
@vjik vjik deleted the symfony7 branch December 26, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants