Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set custom config merge plan file path, config and vendor directories #50

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Mar 9, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues

Copy link

what-the-diff bot commented Mar 9, 2024

PR Summary

  • Enhanced Customizability in ConsoleApplicationRunner Class
    The ability to set a custom configuration merge plan file path and config and vendor directories has been added. This provides users more flexibility adjusting to their specific needs.

  • Requirements Update in Dependencies
    The required version of the 'yiisoft/yii-runner' dependency has been updated to "^2.2". Bringing the system in line with the latest stable version of the dependency for improved performance and stability.

  • Additional Test Suite
    A 'Unit.suite.yml' file was added, potentially increasing detailed testing capabilities and ensuring code quality.

  • New Test Class
    The 'ConsoleApplicationRunnerTest' class along with related files were added in the 'Unit' directory. This is to confirm the controller's actions are producing the expected results.

  • Custom Configuration Files
    New custom configuration files were tucked in under the 'Unit/Support/custom-config' and 'Unit/Support/custom-merge-plan/config' directories, likely to mimic various user environments for thorough testing.

  • New 'UnitTester' Class
    A new 'UnitTester' class was added in the 'tests_support' directory, it stands to reason that this enhancement is to streamline and improve unit testing.

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.60%. Comparing base (587fe6c) to head (99445b5).

Additional details and impacted files
@@              Coverage Diff              @@
##             master      #50       +/-   ##
=============================================
+ Coverage          0   60.60%   +60.60%     
- Complexity        0        3        +3     
=============================================
  Files             0        1        +1     
  Lines             0       33       +33     
=============================================
+ Hits              0       20       +20     
- Misses            0       13       +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team March 9, 2024 14:51
@vjik vjik added the status:code review The pull request needs review. label Mar 9, 2024
@vjik vjik merged commit 154d0d9 into master Mar 10, 2024
22 checks passed
@vjik vjik deleted the new-runner branch March 10, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants